• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • Jenkins 2.363
    • 2.463

      The small buttons and icons in the build history widget are misaligned, if there are more than 3.

      Take a look at the screenshots, the ones prefixed with old_ were taken on Jenkins 2.303.3, and new_ were taken on 2.363.

      The old design aligned all items in a row, while the new design adds an additional row with 1 item, if the build finished.
      This design, the latter, used to be the building state on 2.303.3, as we can we on the screenshots, while the new building state is a mess, that doesn't follow any (previous) alignment pattern.

        1. new_building.png
          new_building.png
          28 kB
        2. new_success.png
          new_success.png
          36 kB
        3. old_building.png
          old_building.png
          24 kB
        4. old_success.png
          old_success.png
          30 kB

          [JENKINS-69342] Icon misalignment in executor history widget

          Daniel Beck added a comment -

          Might be a result of increasing the available width for other elements, such as the build number cutoff in Safari. At some point, these icons need to flow into the next row (although the building one looks weird, granted).

          This is why I keep warning about changes to this widget…

          Daniel Beck added a comment - Might be a result of increasing the available width for other elements, such as the build number cutoff in Safari. At some point, these icons need to flow into the next row (although the building one looks weird, granted). This is why I keep warning about changes to this widget…

          Basil Crow added a comment -

          How hard would it be to burn this widget to the ground and rewrite it from scratch? I'm asking as someone who couldn't do this right now if my life depended on it. But I am curious, how hard could this be?

          Basil Crow added a comment - How hard would it be to burn this widget to the ground and rewrite it from scratch? I'm asking as someone who couldn't do this right now if my life depended on it. But I am curious, how hard could this be?

          Daniel Beck added a comment -

          Most problems seem to come from the desire to use very little space as efficiently as possible.

          A successful rewrite probably needs to start with requirements gathering and understanding various use cases (descriptions, badges, build names, …).

          An argument could be made this should just be a separate page, or a more prominent widget elsewhere (Jan demoed something related in the last UX SIG) to make all these alignment issues obsolete.

          Daniel Beck added a comment - Most problems seem to come from the desire to use very little space as efficiently as possible. A successful rewrite probably needs to start with requirements gathering and understanding various use cases (descriptions, badges, build names, …). An argument could be made this should just be a separate page, or a more prominent widget elsewhere (Jan demoed something related in the last UX SIG) to make all these alignment issues obsolete.

          Basil Crow added a comment -

          A successful rewrite probably needs to start with requirements gathering and understanding various use cases (descriptions, badges, build names, …).

          I know that Daniel, that is the case for any software project. I meant how hard would it be to either reimplement the same widget from scratch or a revised design. I don't think it "should" be too difficult, but it probably is for some historical reasons.

          Basil Crow added a comment - A successful rewrite probably needs to start with requirements gathering and understanding various use cases (descriptions, badges, build names, …). I know that Daniel, that is the case for any software project. I meant how hard would it be to either reimplement the same widget from scratch or a revised design. I don't think it "should" be too difficult, but it probably is for some historical reasons.

          Markus Winter added a comment -

          With https://github.com/jenkinsci/jenkins/pull/9148 the build history widget was rewritten and no longer shows the weird wrapping

          Markus Winter added a comment - With https://github.com/jenkinsci/jenkins/pull/9148 the build history widget was rewritten and no longer shows the weird wrapping

          Daniel Beck added a comment -

          Removing lts-candidate, the size of the change pretty much disqualifies it from backporting.

          Daniel Beck added a comment - Removing lts-candidate, the size of the change pretty much disqualifies it from backporting.

            Unassigned Unassigned
            notmyfault Alexander Brandes
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: