• Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Critical Critical
    • gradle-plugin
    • None
    • Jenkins v 2.392
      Latest Gradle plugin version

      Similar to the fix for JENKINS-70139 to have booleanRadio use non-unique IDs in core Jenkins, the radioBlock construct has generated IDs, so when you have a repeatable describable (e.g. Gradle build step) then this ID will be duplicated for all instances.

      Gradle plugin example with the Build steps as repeatable sections where you choose the Gradle executable. Only one radio button can be selected in the whole group.

      https://github.com/jenkinsci/gradle-plugin/blob/master/src/main/resources/hudson/plugins/gradle/Gradle/config.jelly#L5

       

          [JENKINS-70739] Gradle step radioBlock uses non-unique ID

          I went ahead and closed the PR I created to revert this behavior. The overall consensus is that using radios without an ID is considered a plugin issue and not supported by Jenkins itself. As already advised by drulli, this needs to be improved in the corresponding plugins, by adding and ID to their affected radios.

          cc avenderov jprinet

          Alexander Brandes added a comment - I went ahead and closed the PR I created to revert this behavior. The overall consensus is that using radios without an ID is considered a plugin issue and not supported by Jenkins itself. As already advised by drulli , this needs to be improved in the corresponding plugins, by adding and ID to their affected radios. cc avenderov jprinet

          Joe Hansche added a comment -

          So what's the next step here then? Individual issues need to be created for each plugin having this issue, and address each one separately?

          Joe Hansche added a comment - So what's the next step here then? Individual issues need to be created for each plugin having this issue, and address each one separately?

          Tom added a comment -

          I think I will go ahead and split this into 3 JIRAs, 1 per plugin. I will repurpose this one to be the Gradle plugin.

          Tom added a comment - I think I will go ahead and split this into 3 JIRAs, 1 per plugin. I will repurpose this one to be the Gradle plugin.

          Tom added a comment -

          This Jira is now just for the Gradle plugin issue. JENKINS-70988 is for the Credentials Binding plugin issue, and JENKINS-70989 is for the File Operations plugin issue.

          Tom added a comment - This Jira is now just for the Gradle plugin issue. JENKINS-70988 is for the Credentials Binding plugin issue, and JENKINS-70989 is for the File Operations plugin issue.

          Tom added a comment -

          This is preventing us from upgrading beyond 2.391 of Jenkins.

          Tom added a comment - This is preventing us from upgrading beyond 2.391 of Jenkins.

          Jesse Glick added a comment -

          The fix I proposed for JENKINS-70988 may solve the issue with Gradle as well.

          Jesse Glick added a comment - The fix I proposed for JENKINS-70988 may solve the issue with Gradle as well.

          Mark Waite added a comment -

          I could not duplicate the problem in the current release using the gradle plugin.  It worked as expected in both the current release and with the fix from Jesse.

          It would be very nice if one of those who can duplicate the issue on the current release would test the fix from Jesse to confirm that it resolves the issue. tbeukhof would you be willing to perform that test?

          Mark Waite added a comment - I could not duplicate the problem in the current release using the gradle plugin.  It worked as expected in both the current release and with the fix from Jesse. It would be very nice if one of those who can duplicate the issue on the current release would test the fix from Jesse to confirm that it resolves the issue. tbeukhof would you be willing to perform that test?

          Tom added a comment -

          Yes, Jesse's change fixes this as well. Thank you!

          Tom added a comment - Yes, Jesse's change fixes this as well. Thank you!

          Mark Waite added a comment -

          Fixed by Jesse's change in JENKINS-70988. No change needed in the plugin. Closing as a duplicate

          Mark Waite added a comment - Fixed by Jesse's change in JENKINS-70988 . No change needed in the plugin. Closing as a duplicate

          Joe Hansche added a comment -

          Confirmed: 2.400 fixes this for Gradle build steps.

          Joe Hansche added a comment - Confirmed: 2.400 fixes this for Gradle build steps.

            Unassigned Unassigned
            tbeukhof Tom
            Votes:
            6 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: