Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-70988

Credentials Binding step repeatable property uses non-unique ID

    • 2.400

      Similar to the fix for JENKINS-70139 to have booleanRadio use non-unique IDs in core Jenkins, the repeatableHeteroProperty construct has generated IDs, so when you have a repeatable describable (e.g. Credentials Binding step) then this ID will be duplicated for all instances.

      Credentials Binding plugin example - you can see in the repeating Username and password (separated) sections only one radio button can be selected / active. This is more than just visual, the values are not enabled.

      https://github.com/jenkinsci/credentials-binding-plugin/blob/master/src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly#L34

          [JENKINS-70988] Credentials Binding step repeatable property uses non-unique ID

          Tom created issue -
          Tom made changes -
          Description Original: When you have a repeatable describable (e.g. quality gates in the warnings plugin, or code coverage plugin) then this ID will be duplicated for all instances, i.e. the button will be toggled automatically for all instances rather than for the selected one only. We need to provide a way to make this ID unique. New: Similar to the fix for JENKINS-70139 to have booleanRadio use non-unique IDs in core Jenkins, the repeatableHeteroProperty construct has generated IDs, so when you have a repeatable describable (e.g. Credentials Binding step) then this ID will be duplicated for all instances.

          Credentials Binding plugin example - you can see in the repeating Username and password (separated) sections only one radio button can be selected / active. This is more than just visual, the values are not enabled.

          [https://github.com/jenkinsci/credentials-binding-plugin/blob/master/src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly#L34]

          !credentialBinding.png!
          Tom made changes -
          Attachment New: credentialBinding.png [ 60211 ]
          Tom made changes -
          Link New: This issue is related to JENKINS-70139 [ JENKINS-70139 ]
          Tom made changes -
          Link New: This issue is related to JENKINS-70739 [ JENKINS-70739 ]

          Tom added a comment -

          This is preventing us from upgrading beyond Jenkins 2.391

          Tom added a comment - This is preventing us from upgrading beyond Jenkins 2.391

          james added a comment -

          We are seeing this on the FreeStyle Project config page when doing bindings as well. It started at 2.391 and continues through 2.397 which is the last version we have tested for this. 

          james added a comment - We are seeing this on the FreeStyle Project config page when doing bindings as well. It started at 2.391 and continues through 2.397 which is the last version we have tested for this. 
          Jesse Glick made changes -
          Component/s New: credentials-plugin [ 16523 ]

          Jesse Glick added a comment -

          I suspect the problem lies not in the credentials-binding plugin itself, but in these low-level form controls in the credentials plugin.

          Jesse Glick added a comment - I suspect the problem lies not in the credentials-binding plugin itself, but in these low-level form controls in the credentials plugin.
          Jesse Glick made changes -
          Component/s New: core [ 15593 ]

            jglick Jesse Glick
            tbeukhof Tom
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: