Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-71236

Stapler Ajax Proxy is broken (regression in 2.404)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • core
    • Jenkins 2.404
    • 2.405

      One of the JENKINS-70906 refactorings that remove Prototype.js did break the visualization of trend charts. All trends now fail with

      caught (in promise) SyntaxError: "undefined" is not valid JSON
          at JSON.parse (<anonymous>)
          at redraw (trend-chart.js:96:44)
          at trend-chart.js:132:13
          at bind.js:52:33
      

      I'm not sure if this is related to JENKINS-71230

          [JENKINS-71236] Stapler Ajax Proxy is broken (regression in 2.404)

          Ulli Hafner added a comment -

          Ulli Hafner added a comment - Broken ATH test: https://github.com/jenkinsci/warnings-ng-plugin/actions/runs/4935685836/jobs/8822317785?pr=1519

          Basil Crow added a comment -

          Caused by jenkinsci/stapler#452.

          Broken ATH test

          It is unfortunate that you have chosen a nonstandard configuration rather than placing your tests in jenkinsci/acceptance-test-harness. Had you followed the standard practice, this regression would have been caught before it shipped to production users.

          Basil Crow added a comment - Caused by jenkinsci/stapler#452 . Broken ATH test It is unfortunate that you have chosen a nonstandard configuration rather than placing your tests in jenkinsci/acceptance-test-harness . Had you followed the standard practice, this regression would have been caught before it shipped to production users.

          Ulli Hafner added a comment -

          It is unfortunate that you have chosen a nonstandard configuration rather than placing your tests in jenkinsci/acceptance-test-harness. Had you followed the standard practice, this regression would have been caught before it shipped to production users.

          Actually the former ATH team (Oliver, Kohsuke, Oleg, me) decided to move plugin UI tests to the plugins code base, so I am conforming to this standard. If we want to revert that decision we need to discuss that in a more general context.

          Ulli Hafner added a comment - It is unfortunate that you have chosen a nonstandard configuration rather than placing your tests in jenkinsci/acceptance-test-harness. Had you followed the standard practice, this regression would have been caught before it shipped to production users. Actually the former ATH team (Oliver, Kohsuke, Oleg, me) decided to move plugin UI tests to the plugins code base, so I am conforming to this standard. If we want to revert that decision we need to discuss that in a more general context.

          Basil Crow added a comment -

          I think that decision was premature without a way to run all ATH tests against an unreleased core PR. I tested the recent Prototype removal PRs against the ATH tests in acceptance-test-harness, and they passed, but there was a bug that was not caught because your ATH tests are not in that repository.

          Basil Crow added a comment - I think that decision was premature without a way to run all ATH tests against an unreleased core PR. I tested the recent Prototype removal PRs against the ATH tests in acceptance-test-harness , and they passed, but there was a bug that was not caught because your ATH tests are not in that repository.

          Ulli Hafner added a comment -

          Yes, if we want to use ATH tests for plugin PRs and core PRs then we need to improve and change the architecture again. I am open to any ideas on how to satisfy both worlds (plugin and core contributors).

          Ulli Hafner added a comment - Yes, if we want to use ATH tests for plugin PRs and core PRs then we need to improve and change the architecture again. I am open to any ideas on how to satisfy both worlds (plugin and core contributors).

            basil Basil Crow
            drulli Ulli Hafner
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: