Details
-
Type:
Bug
-
Status: Reopened (View Workflow)
-
Priority:
Minor
-
Resolution: Unresolved
-
Component/s: pipeline
-
Labels:
-
Environment:Jenkins 1.609.1 on both MacOS and Linux
-
Similar Issues:
Description
In a Workflow build, if you use certain resources in >1 node, you get duplication of the links in the left navigation pane when you look at the info page for a build that has already run. To reproduce, install the Workflow plugin, create a new Workflow job, and give it a configuration like:
node {
git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
}
node {
git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
}
node {
git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
}
Each time you use the git resource within a new node, it causes duplication of the nav items as shown in the attached screenshot. This issue is not confined to the workflow+git combination. I have also seen it with the 'Show Build Parameters' plugin, where there is duplication of the Parameters link in the nav pane, but I can't seem to reproduce that issue consistently. I suspect that other plugins which add something to the nav field on a per-job basis could have similar issues.
I'm attaching a support bundle from my MacOS test Jenkins server, and also a build.xml that shows the issue.
Attachments
Issue Links
- is blocking
-
-
- Open
-
-
-
- Resolved
-
- is duplicated by
-
-
- Resolved
-
-
-
- Closed
-
- is related to
-
-
- Open
-
-
-
- Open
-
-
-
- Open
-
-
-
- Open
-
-
-
- Open
-
-
-
- Closed
-
-
-
- Resolved
-
- relates to
-
-
- Open
-
- links to
Activity
This is happening to me today on Jenkins 2.89.2 LTS with Pipeline Job 2.16. I've got 3 "Git Build Data" links in the left-hand menu (URLs ending in "git", "git-2", and "git-3"), and moreover, the main panel lists three Git revision SHAs that aren't actually part of my repository. This is a Multibranch Pipeline job building a pull request using the default "Merging the pull request with the current target branch revision" behavior. It also shows two Changes sections in the main panel listing the same Git commit message twice, in case that's relevant or related.
Did someone revert the fix? It's showing five for me.
Code changed in jenkins
User: Andrew Bayer
Path:
job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java
http://jenkins-ci.org/commit/workflow-job-plugin/ec2575b1f03ea1bb4cce4d53c2b78aec626e5c28
Log:
Merge pull request #271 from abayer/jenkins-29326
JENKINS-29326 Don't add duplicate BuildData (downstream)
Originally-Committed-As: 3840d8ca847ed0ea8097c2f62e7b21504190afad
Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/hudson/plugins/git/util/BuildData.java
http://jenkins-ci.org/commit/git-plugin/7e501ab38c60ad203cd5f1cdce8a9683c4fb89d8
Log:
[FIXED JENKINS-29326] Restore lost BuildData.equals override.
May I ask why is this Priority: Minor?
Can this be escalated?
There are like dozens of duplicates of this issue (see e.g. JENKINS-38204 – the SVN lineage of dupes), and it looks like it's getting "fixed", then broken, then fixed again, then broken again... Is this an architectural problem in Jenkins?
Can anybody fix this once-and-for-all?