Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29326

Workflow sidebar has duplicated Git Build Data links

      In a Workflow build, if you use certain resources in >1 node, you get duplication of the links in the left navigation pane when you look at the info page for a build that has already run. To reproduce, install the Workflow plugin, create a new Workflow job, and give it a configuration like:

      node {
        git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
      }
      node {
        git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
      }
      node {
        git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
      }
      

      Each time you use the git resource within a new node, it causes duplication of the nav items as shown in the attached screenshot. This issue is not confined to the workflow+git combination. I have also seen it with the 'Show Build Parameters' plugin, where there is duplication of the Parameters link in the nav pane, but I can't seem to reproduce that issue consistently. I suspect that other plugins which add something to the nav field on a per-job basis could have similar issues.

      I'm attaching a support bundle from my MacOS test Jenkins server, and also a build.xml that shows the issue.

        1. Screen Shot 2017-10-26 at 9.53.46 am.png
          17 kB
          trejkaz
        2. Screen Shot 2015-07-09 at 12.01.47 PM.png
          129 kB
          Owen Mehegan
        3. jenkins.log
          11 kB
          Martin d'Anjou
        4. build.xml
          10 kB
          Owen Mehegan

          [JENKINS-29326] Workflow sidebar has duplicated Git Build Data links

          Owen Mehegan created issue -
          Jesse Glick made changes -
          Component/s Original: core [ 15593 ]

          Jesse Glick added a comment -

          The multiple Git Build Data links is a known issue; possibly a bug in the Git plugin, needs to be investigated. In general if a plugin was expecting something it ran to only ever be called once per build, but from a workflow it is potentially called multiple times, then it needs to be modified to make sure it does not call Run.addAction multiple times on the same build with the same class of action unless this is really intentional (for example if each instance has a distinctive displayName).

          If you see duplicated sidebar links of another kind, better to file a separate issue, with steps to reproduce if possible.

          Jesse Glick added a comment - The multiple Git Build Data links is a known issue; possibly a bug in the Git plugin, needs to be investigated. In general if a plugin was expecting something it ran to only ever be called once per build, but from a workflow it is potentially called multiple times, then it needs to be modified to make sure it does not call Run.addAction multiple times on the same build with the same class of action unless this is really intentional (for example if each instance has a distinctive displayName ). If you see duplicated sidebar links of another kind, better to file a separate issue, with steps to reproduce if possible.
          Jesse Glick made changes -
          Summary Original: Workflow job build view has duplicate items in left navigation list New: Workflow sidebar has duplicated Git Build Data links
          Jesse Glick made changes -
          Description Original: In a Workflow build, if you use certain resources in >1 node, you get duplication of the links in the left navigation pane when you look at the info page for a build that has already run. To reproduce, install the Workflow plugin, create a new Workflow job, and give it a configuration like:

          node {
            git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
          }
          node {
            git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
          }
          node {
            git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
          }

          Each time you use the git resource within a new node, it causes duplication of the nav items as shown in the attached screenshot. This issue is not confined to the workflow+git combination. I have also seen it with the 'Show Build Parameters' plugin, where there is duplication of the Parameters link in the nav pane, but I can't seem to reproduce that issue consistently. I suspect that other plugins which add something to the nav field on a per-job basis could have similar issues.

          I'm attaching a support bundle from my MacOS test Jenkins server, and also a build.xml that shows the issue.
          New: In a Workflow build, if you use certain resources in >1 node, you get duplication of the links in the left navigation pane when you look at the info page for a build that has already run. To reproduce, install the Workflow plugin, create a new Workflow job, and give it a configuration like:

          {code}
          node {
            git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
          }
          node {
            git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
          }
          node {
            git branch: "master", credentialsId: '', url: 'git@mygitrepo/project.git'
          }
          {code}

          Each time you use the git resource within a new node, it causes duplication of the nav items as shown in the attached screenshot. This issue is not confined to the workflow+git combination. I have also seen it with the 'Show Build Parameters' plugin, where there is duplication of the Parameters link in the nav pane, but I can't seem to reproduce that issue consistently. I suspect that other plugins which add something to the nav field on a per-job basis could have similar issues.

          I'm attaching a support bundle from my MacOS test Jenkins server, and also a build.xml that shows the issue.
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-29840 [ JENKINS-29840 ]

          Owen Mehegan added a comment -

          Tagging with git-plugin and optimistically assigning to Mark to take a look

          Owen Mehegan added a comment - Tagging with git-plugin and optimistically assigning to Mark to take a look
          Owen Mehegan made changes -
          Component/s New: git-plugin [ 15543 ]
          Assignee Original: Jesse Glick [ jglick ] New: Mark Waite [ markewaite ]

          Jesse Glick added a comment -

          Reverting, I had this where I wanted it.

          Jesse Glick added a comment - Reverting, I had this where I wanted it.
          Jesse Glick made changes -
          Component/s Original: git-plugin [ 15543 ]
          Assignee Original: Mark Waite [ markewaite ] New: Jesse Glick [ jglick ]

            Unassigned Unassigned
            owenmehegan Owen Mehegan
            Votes:
            28 Vote for this issue
            Watchers:
            37 Start watching this issue

              Created:
              Updated: