Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31314

Running asynchronous code inside a @NonCPS method should fail cleanly

    XMLWordPrintable

Details

    • workflow-cps 2.71

    Description

      User-visible bit: throws an error

       

      Currently if you run a step with asynchronous execution (which is to say, almost all of them, since AbstractSynchronousNonBlockingStepExecution counts) inside a method marked @NonCPS, or otherwise not transformed (for example because of JENKINS-26481), you get bizarre results: the return value of the step becomes the return value of the method, regardless of what was supposed to happen in the rest of the method. This is because CpsCallableInvocation is thrown from DSL.invokeMethod and interrupts the method's execution.

      This is very confusing behavior. It would be better for CpsCallableInvocation.<init> to somehow detect that it is inside an untransformed method and throw a comprehensible error.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-60552 Fail to call a script method stored as a class attribute/field

          • Blocker - Blocks development and/or testing work, production could not run.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-58501 Metaprogramming with InvokerHelper and MethodMissing triggers CPS MisMatch log

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-58620 expected to call CpsGroovyShell.evaluate but wound up catching <something>.run

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-38317 Input step breaks out of global library

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-39042 CPS failures from calls in @NonCPS blocks fail silently and marks as success

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-42024 Silent error : UnsupportedOperationExceptions are not raised when using each/find

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26481 Mishandling of binary methods accepting Closure

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-32863 Sleep function causes premature exit of loop in some cases

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-59667 CpsCallableInvocation.checkMismatch with @NonCPS method calling simple groovy getter (not any step)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-58407 Fail to call a Closure stored as a class attribute/field

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26313 Workflow script fails if CPS-transformed methods are called from constructors

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27306 unclassified new org.codehaus.groovy.runtime.GStringImpl java.lang.String java.lang.String[]

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-38915 Document limitations of language coverage

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          links to

          Web Link CloudBees Internal CD-49

          Web Link groovy-cps #9

          Web Link groovy-cps PR 85

          Web Link jenkins.io #2290

          Web Link PR 233 (test only)

          Web Link workflow-cps PR 211

          Wiki Page

          Wiki Page Loading...

          Activity

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              16 Vote for this issue
              Watchers:
              27 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: