Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37658

Github-branch-source plugin should support git plugin extensions

    • Icon: Improvement Improvement
    • Resolution: Duplicate
    • Icon: Major Major
    • Jenkins v2.17, Github-branch-source-plugin 1.9

      Github branch source should support all the same extensions as the git client plugin ("Clean Before Checkout", "Clean After Checkout ", etc). it currently does not provide a way to add them, while other pipeline plugins do support them.

      See "Additional Behaviors" in the attached screenshot.

          [JENKINS-37658] Github-branch-source plugin should support git plugin extensions

          Jesse Glick added a comment -

          scm should include whatever extensions the branch source was configured to use.

          Jesse Glick added a comment - scm should include whatever extensions the branch source was configured to use.

          But that doesn't make sense when using the github org folders. Different repos would want different settings. Also you can't set them in github org folders.

          Christian Höltje added a comment - But that doesn't make sense when using the github org folders. Different repos would want different settings. Also you can't set them in github org folders.

          Jesse Glick added a comment -

          Different repos would want different settings.

          Well that would need to be an RFE. Not currently supported—all repositories must use identical settings, except for the remote URL of course. If you want something more complex you need to use Job DSL.

          Jesse Glick added a comment - Different repos would want different settings. Well that would need to be an RFE. Not currently supported—all repositories must use identical settings, except for the remote URL of course. If you want something more complex you need to use Job DSL.

          I created a new RFE, JENKINS-39750.

          Using JobDSL isn't suitable because I'd have to duplicate all the functionality of the GitHub Org Plugin (scanning GitHub, etc.) in the JobDSL, which would be very annoying. And it would still require whomever maintained the jobDSL to know things in advanced (like what the credentials-id is, the URLs, etc.)

          Christian Höltje added a comment - I created a new RFE, JENKINS-39750 . Using JobDSL isn't suitable because I'd have to duplicate all the functionality of the GitHub Org Plugin (scanning GitHub, etc.) in the JobDSL, which would be very annoying. And it would still require whomever maintained the jobDSL to know things in advanced (like what the credentials-id is, the URLs, etc.)

          marc young added a comment -

          This is still an issue even with all the SCM 2.0 work.
          Linking JENKINS-42351

          marc young added a comment - This is still an issue even with all the SCM 2.0 work. Linking JENKINS-42351

          P S added a comment -

          Related ticket: JENKINS-42947

          P S added a comment - Related ticket:  JENKINS-42947

          Liam Newman added a comment -

          stephenconnolly
          Could you describe why you resolved this a duplicate? I can see that the linked issue has some overlap with this one, but it is not the same thing. This requests that the github branch plugin support the same open-ended set of extensions that the git plugin does. The linked issue implements a limited subset with a different UI.

          Liam Newman added a comment - stephenconnolly Could you describe why you resolved this a duplicate? I can see that the linked issue has some overlap with this one, but it is not the same thing. This requests that the github branch plugin support the same open-ended set of extensions that the git plugin does. The linked issue implements a limited subset with a different UI.

          bitwiseman All the extensions available on Git SCM Source are now available on GitHub and Bitbucket (except the ability to set the source code browser, because on GitHub and Bitbucket the only browser to set it to is GitHub / Bitbucket Respectively)

          There were a number of extensions on GitSCM that were exposed to GitSCMSource and should never have been. Those extensions have been removed from GitSCMSource and subclasses.

          The GitHub plugin now supports all the GitSCMExtensions that are relevant in the context of an SCMSource, hence duplicate

          Stephen Connolly added a comment - bitwiseman All the extensions available on Git SCM Source are now available on GitHub and Bitbucket (except the ability to set the source code browser, because on GitHub and Bitbucket the only browser to set it to is GitHub / Bitbucket Respectively) There were a number of extensions on GitSCM that were exposed to GitSCMSource and should never have been . Those extensions have been removed from GitSCMSource and subclasses. The GitHub plugin now supports all the GitSCMExtensions that are relevant in the context of an SCMSource, hence duplicate

          Liam Newman added a comment -

          stephenconnolly
          Excellent! Thanks!

          Liam Newman added a comment - stephenconnolly Excellent! Thanks!

          What about GitHub organizations? When I create an org there is no way to configure this via the config interface. After digging a lot I found https://support.cloudbees.com/hc/en-us/articles/226122247-How-to-Customize-Checkout-for-Pipeline-Multibranch- which helped to finally be able to do this in the Jenkinsfile, but still it's super complicated and you need to mess with permissions approval.

          Leandro Lucarella added a comment - What about GitHub organizations? When I create an org there is no way to configure this via the config interface. After digging a lot I found https://support.cloudbees.com/hc/en-us/articles/226122247-How-to-Customize-Checkout-for-Pipeline-Multibranch- which helped to finally be able to do this in the Jenkinsfile, but still it's super complicated and you need to mess with permissions approval.

            Unassigned Unassigned
            bitwiseman Liam Newman
            Votes:
            44 Vote for this issue
            Watchers:
            43 Start watching this issue

              Created:
              Updated:
              Resolved: