• Type: Bug
• Resolution: Duplicate
• Priority: Minor
• Component/s: pipeline-model-definition-plugin
• Labels:

  • declarative
  • pipeline
  • script-security

1. Jenkinsfile

   5 kB

   2017-04-18 17:27

2. dockerCompose.groovy

   2 kB

   2017-04-26 11:59

[JENKINS-43635] declarative pipeline fails with workflow library

davidkarlsen created issue - 2017-04-17 20:45

davidkarlsen made changes - 2017-04-17 20:46

Description

Original: I have some multibranch pipelines, where I want to move over to the declarative pipeline syntax. I use a shared workflow library (added implicitly to all jobs, set as the default in the master config). When using declarative pipelines I get \{noformat} 21:38:23 + docker-compose -f docker-compose.yml ps 21:38:24 stty: standard input: Inappropriate ioctl for device 21:38:24 Name Command State Ports 21:38:24 ----------------------------------------------------------------------------------------------------------------------------- 21:38:24 serverfeaturetacjfrsr167b43eenhq7fwkjpebbaprznkzesfair6fcv3a7pw26uh2fvuomq5a_oracle_1 /bin/sh -c /run.sh Up 1521/tcp [Pipeline] sh 21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script [Pipeline] sh 21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script [Pipeline] } ..... Caused by: java.lang.UnsupportedOperationException: Refusing to marshal org.codehaus.groovy.runtime.GStringImpl for security reasons \{noformat} when running the helper method from my pipeline library. The same helper method with the same arguments works just fine in a "classic" style Jenkinsfile pipeline.  So I headed off and put @NonCPS on the helper-method, the strange thing is that I then get another return type from that method! w/o annotation it's a List as expected, with annotation it becomes a String: \{noformat} |java.lang.ClassCastException: org.jenkinsci.plugins.workflow.steps.EnvStep.overrides expects java.util.List<java.lang.String> but received class java.lang.String| | | \{noformat} It seems strange that the same pipeline-library behaves differently between the two pipeline styles of declaration. See gist for full details: https://gist.github.com/davidkarlsen/882af8fa46859134aa3502fd5921cb79#file-gistfile1-txt-L5

New: I have some multibranch pipelines, where I want to move over to the declarative pipeline syntax. I use a shared workflow library (added implicitly to all jobs, set as the default in the master config). When using declarative pipelines I get {noformat} 21:38:23 + docker-compose -f docker-compose.yml ps 21:38:24 stty: standard input: Inappropriate ioctl for device 21:38:24 Name Command State Ports 21:38:24 ----------------------------------------------------------------------------------------------------------------------------- 21:38:24 serverfeaturetacjfrsr167b43eenhq7fwkjpebbaprznkzesfair6fcv3a7pw26uh2fvuomq5a_oracle_1 /bin/sh -c /run.sh Up 1521/tcp [Pipeline] sh 21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script [Pipeline] sh 21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script [Pipeline] } ..... Caused by: java.lang.UnsupportedOperationException: Refusing to marshal org.codehaus.groovy.runtime.GStringImpl for security reasons {noformat} when running the helper method from my pipeline library. The same helper method with the same arguments works just fine in a "classic" style Jenkinsfile pipeline.  So I headed off and put @NonCPS on the helper-method, the strange thing is that I then get another return type from that method! w/o annotation it's a List as expected, with annotation it becomes a String: {noformat} java.lang.ClassCastException: org.jenkinsci.plugins.workflow.steps.EnvStep.overrides expects java.util.List<java.lang.String> but received class java.lang.String   {noformat} It seems strange that the same pipeline-library behaves differently between the two pipeline styles of declaration. See gist for full details: https://gist.github.com/davidkarlsen/882af8fa46859134aa3502fd5921cb79#file-gistfile1-txt-L5

Andrew Bayer made changes - 2017-04-18 16:51

Component/s		New: pipeline-model-definition-plugin [ 21706 ]
Component/s	Original: pipeline [ 21692 ]

Andrew Bayer made changes - 2017-04-18 16:51

Assignee

New: Andrew Bayer [ abayer ]

Collapse comment: Andrew Bayer added a comment - 2017-04-18 16:52

Andrew Bayer added a comment - 2017-04-18 16:52

Can you include the Jenkinsfile (or a dummy Jenkinsfile that reproduces the error) as well?

Expand comment: Andrew Bayer added a comment - 2017-04-18 16:52

Andrew Bayer added a comment - 2017-04-18 16:52 Can you include the Jenkinsfile (or a dummy Jenkinsfile that reproduces the error) as well?

davidkarlsen made changes - 2017-04-18 17:27

Attachment

New: Jenkinsfile [ 37251 ]

Collapse comment: davidkarlsen added a comment - 2017-04-18 17:28

davidkarlsen added a comment - 2017-04-18 17:28

abayer attached.
Maybe you need the workflow lib as well?

Expand comment: davidkarlsen added a comment - 2017-04-18 17:28

davidkarlsen added a comment - 2017-04-18 17:28 abayer attached. Maybe you need the workflow lib as well?

Collapse comment: Andrew Bayer added a comment - 2017-04-18 17:35

Andrew Bayer added a comment - 2017-04-18 17:35

You've got that in the gist, I think, but attaching it here wouldn't hurt.

Expand comment: Andrew Bayer added a comment - 2017-04-18 17:35

Andrew Bayer added a comment - 2017-04-18 17:35 You've got that in the gist, I think, but attaching it here wouldn't hurt.

davidkarlsen made changes - 2017-04-26 11:59

Attachment

New: dockerCompose.groovy [ 37444 ]

Collapse comment: davidkarlsen added a comment - 2017-04-26 12:00

davidkarlsen added a comment - 2017-04-26 12:00

abayer done

Expand comment: davidkarlsen added a comment - 2017-04-26 12:00

davidkarlsen added a comment - 2017-04-26 12:00 abayer done

Load more newer events