Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43635

declarative pipeline fails with workflow library

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I have some multibranch pipelines, where I want to move over to the declarative pipeline syntax.
      I use a shared workflow library (added implicitly to all jobs, set as the default in the master config).
      When using declarative pipelines I get

      21:38:23 + docker-compose -f docker-compose.yml ps
      21:38:24 stty: standard input: Inappropriate ioctl for device
      21:38:24 Name Command State Ports 
      21:38:24 -----------------------------------------------------------------------------------------------------------------------------
      21:38:24 serverfeaturetacjfrsr167b43eenhq7fwkjpebbaprznkzesfair6fcv3a7pw26uh2fvuomq5a_oracle_1 /bin/sh -c /run.sh Up 1521/tcp 
      [Pipeline] sh
      21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script
      [Pipeline] sh
      21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script
      [Pipeline] }
      .....
      Caused by: java.lang.UnsupportedOperationException: Refusing to marshal org.codehaus.groovy.runtime.GStringImpl for security reasons
      

      when running the helper method from my pipeline library. The same helper method with the same arguments works just fine in a "classic" style Jenkinsfile pipeline. 
      So I headed off and put @NonCPS on the helper-method, the strange thing is that I then get another return type from that method! w/o annotation it's a List as expected, with annotation it becomes a String:

      java.lang.ClassCastException: org.jenkinsci.plugins.workflow.steps.EnvStep.overrides expects java.util.List<java.lang.String> but received class java.lang.String
       
      

      It seems strange that the same pipeline-library behaves differently between the two pipeline styles of declaration.
      See gist for full details:
      https://gist.github.com/davidkarlsen/882af8fa46859134aa3502fd5921cb79#file-gistfile1-txt-L5

        Attachments

          Issue Links

            Activity

            davidkarlsen davidkarlsen created issue -
            davidkarlsen davidkarlsen made changes -
            Field Original Value New Value
            Description I have some multibranch pipelines, where I want to move over to the declarative pipeline syntax.

            I use a shared workflow library (added implicitly to all jobs, set as the default in the master config).

            When using declarative pipelines I get

            \{noformat}
            21:38:23 + docker-compose -f docker-compose.yml ps
            21:38:24 stty: standard input: Inappropriate ioctl for device
            21:38:24 Name Command State Ports
            21:38:24 -----------------------------------------------------------------------------------------------------------------------------
            21:38:24 serverfeaturetacjfrsr167b43eenhq7fwkjpebbaprznkzesfair6fcv3a7pw26uh2fvuomq5a_oracle_1 /bin/sh -c /run.sh Up 1521/tcp
            [Pipeline] sh
            21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script
            [Pipeline] sh
            21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script
            [Pipeline] }
            .....
            Caused by: java.lang.UnsupportedOperationException: Refusing to marshal org.codehaus.groovy.runtime.GStringImpl for security reasons
            \{noformat}

            when running the helper method from my pipeline library. The same helper method with the same arguments works just fine in a "classic" style Jenkinsfile pipeline. 

            So I headed off and put @NonCPS on the helper-method, the strange thing is that I then get another return type from that method! w/o annotation it's a List as expected, with annotation it becomes a String:

            \{noformat}
            |java.lang.ClassCastException: org.jenkinsci.plugins.workflow.steps.EnvStep.overrides expects java.util.List<java.lang.String> but received class java.lang.String|
            | |

            \{noformat}

            It seems strange that the same pipeline-library behaves differently between the two pipeline styles of declaration.

            See gist for full details:

            https://gist.github.com/davidkarlsen/882af8fa46859134aa3502fd5921cb79#file-gistfile1-txt-L5
            I have some multibranch pipelines, where I want to move over to the declarative pipeline syntax.
            I use a shared workflow library (added implicitly to all jobs, set as the default in the master config).
            When using declarative pipelines I get
            {noformat}
            21:38:23 + docker-compose -f docker-compose.yml ps
            21:38:24 stty: standard input: Inappropriate ioctl for device
            21:38:24 Name Command State Ports
            21:38:24 -----------------------------------------------------------------------------------------------------------------------------
            21:38:24 serverfeaturetacjfrsr167b43eenhq7fwkjpebbaprznkzesfair6fcv3a7pw26uh2fvuomq5a_oracle_1 /bin/sh -c /run.sh Up 1521/tcp
            [Pipeline] sh
            21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script
            [Pipeline] sh
            21:38:24 [server_feature_TACJFRSR-167-B43EENHQ7FWKJPEBBAPRZNKZESFAIR6FCV3A7PW26UH2FVUOMQ5A] Running shell script
            [Pipeline] }
            .....
            Caused by: java.lang.UnsupportedOperationException: Refusing to marshal org.codehaus.groovy.runtime.GStringImpl for security reasons
            {noformat}
            when running the helper method from my pipeline library. The same helper method with the same arguments works just fine in a "classic" style Jenkinsfile pipeline. 
            So I headed off and put @NonCPS on the helper-method, the strange thing is that I then get another return type from that method! w/o annotation it's a List as expected, with annotation it becomes a String:
            {noformat}
            java.lang.ClassCastException: org.jenkinsci.plugins.workflow.steps.EnvStep.overrides expects java.util.List<java.lang.String> but received class java.lang.String
             
            {noformat}
            It seems strange that the same pipeline-library behaves differently between the two pipeline styles of declaration.
            See gist for full details:
            https://gist.github.com/davidkarlsen/882af8fa46859134aa3502fd5921cb79#file-gistfile1-txt-L5
            abayer Andrew Bayer made changes -
            Component/s pipeline-model-definition-plugin [ 21706 ]
            Component/s pipeline [ 21692 ]
            abayer Andrew Bayer made changes -
            Assignee Andrew Bayer [ abayer ]
            davidkarlsen davidkarlsen made changes -
            Attachment Jenkinsfile [ 37251 ]
            davidkarlsen davidkarlsen made changes -
            Attachment dockerCompose.groovy [ 37444 ]
            abayer Andrew Bayer made changes -
            Link This issue duplicates JENKINS-42498 [ JENKINS-42498 ]
            abayer Andrew Bayer made changes -
            Resolution Duplicate [ 3 ]
            Status Open [ 1 ] Resolved [ 5 ]
            jamesdumay James Dumay made changes -
            Remote Link This issue links to "CloudBees Internal OSS-2242 (Web Link)" [ 18377 ]
            bitwiseman Liam Newman made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              Assignee:
              abayer Andrew Bayer
              Reporter:
              davidkarlsen davidkarlsen
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: