Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68356

Icons and text contain misalignment and/or visual imbalance in /legend (regression in 2.329)

    XMLWordPrintable

Details

    • 2.347, 2.346.1

    Description

      in the icon legend the text is miss aligned for the new "build status" icons however the text is correctly aligned for the weather icons.

      e.g. https://ci.jenkins.io/legend

      Steps to reproduce

      • Install and configure Jenkins 2.332.2 
      • Visit {{$JENKINS_URL/legend }}.

      Expected results

      Note: These are the actual results when running with Jenkins 2.328.

      • The description of each icon is aligned with the icon in a consistent way.
      • That consistent alignment is with the middle of the icon for visual balance.

      Actual results

      As of Jenkins 2.329, the descriptions of the weather icons remain aligned with the middle of the icon, but the descriptions of the build status icons are aligned with the bottom of the icon. This is inconsistent.

      As of Jenkins 2.345, the descriptions of all icons are aligned with the top of the icon. This is consistent, but it creates a visual imbalance.

      Evaluation

      Bisection shows the original regression was caused by JENKINS-67515 in https://github.com/jenkinsci/jenkins/pull/6162

      potential source of second regression (unconfirmed) could be https://github.com/jenkinsci/jenkins/pull/6341

      Attachments

        Issue Links

          Activity

            teilo James Nord added a comment - could be a dupe of https://issues.jenkins.io/browse/JENKINS-67846
            teilo James Nord added a comment - - edited

            not a dupe of that but even worse in 2.345 as now everything is pushed to the top (even weather looks un aligned)

            (possible cause of regression -> https://github.com/jenkinsci/jenkins/pull/6341 ?)

            teilo James Nord added a comment - - edited not a dupe of that but even worse in 2.345 as now everything is pushed to the top (even weather looks un aligned) (possible cause of regression -> https://github.com/jenkinsci/jenkins/pull/6341 ?)
            basil Basil Crow added a comment -

            also (drive by comment, should be a different issue) the size of the icons looks a little large in comparison to the text size.

            teilo Do not leave drive-by comments on unrelated issues. Kindly file a separate issue regarding the size of the icons.

            basil Basil Crow added a comment - also (drive by comment, should be a different issue) the size of the icons looks a little large in comparison to the text size. teilo Do not leave drive-by comments on unrelated issues. Kindly file a separate issue regarding the size of the icons.
            basil Basil Crow added a comment -

            teilo When filing regression bugs, it is helpful to include the steps to reproduce, expected results, and actual results as described in the Issue Reporting documentation. As a courtesy, I have taken the liberty of providing this information below:

            Steps to reproduce

            • Install Jenkins 2.329.
            • Visit /legend.

            Expected results

            Note: These are the actual results when running with Jenkins 2.328.

            • The description of each icon is aligned with the icon in a consistent way.
            • That consistent alignment is with the middle of the icon for visual balance.

            Actual results

            As of Jenkins 2.329, the descriptions of the weather icons remain aligned with the middle of the icon, but the descriptions of the build status icons are aligned with the bottom of the icon. This is inconsistent.

            As of Jenkins 2.345, the descriptions of all icons are aligned with the top of the icon. This is consistent, but it creates a visual imbalance.

            Evaluation

            Bisection shows the original regression was caused by JENKINS-67515 in jenkinsci/jenkins#6162.

            basil Basil Crow added a comment - teilo When filing regression bugs, it is helpful to include the steps to reproduce, expected results, and actual results as described in the Issue Reporting documentation. As a courtesy, I have taken the liberty of providing this information below: Steps to reproduce Install Jenkins 2.329. Visit /legend . Expected results Note: These are the actual results when running with Jenkins 2.328. The description of each icon is aligned with the icon in a consistent way. That consistent alignment is with the middle of the icon for visual balance. Actual results As of Jenkins 2.329, the descriptions of the weather icons remain aligned with the middle of the icon, but the descriptions of the build status icons are aligned with the bottom of the icon. This is inconsistent. As of Jenkins 2.345, the descriptions of all icons are aligned with the top of the icon. This is consistent, but it creates a visual imbalance. Evaluation Bisection shows the original regression was caused by JENKINS-67515 in jenkinsci/jenkins#6162 .

            People

              frankie699 frankie699
              teilo James Nord
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: