To prevent lazy-loading issues.

          [JENKINS-18410] Use RunAction2 from TestResultAction

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java
          core/src/main/java/hudson/tasks/junit/TestResultAction.java
          core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
          core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java
          core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java
          core/src/main/java/hudson/tasks/test/MatrixTestResult.java
          core/src/main/java/hudson/tasks/test/TestResultAggregator.java
          test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java
          test/src/test/java/hudson/tasks/test/TrivialTestResultRecorder.java
          http://jenkins-ci.org/commit/jenkins/fcdf74991226fb6869052caa89ed8d678944b6fc
          Log:
          [FIXED JENKINS-18410] AbstractTestResultAction should be a RunAction2 so it need not persist its owning build.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java core/src/main/java/hudson/tasks/junit/TestResultAction.java core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java core/src/main/java/hudson/tasks/test/MatrixTestResult.java core/src/main/java/hudson/tasks/test/TestResultAggregator.java test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java test/src/test/java/hudson/tasks/test/TrivialTestResultRecorder.java http://jenkins-ci.org/commit/jenkins/fcdf74991226fb6869052caa89ed8d678944b6fc Log: [FIXED JENKINS-18410] AbstractTestResultAction should be a RunAction2 so it need not persist its owning build.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/tasks/junit/TestResultAction.java
          core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
          core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java
          core/src/main/java/hudson/tasks/test/MatrixTestResult.java
          test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java
          http://jenkins-ci.org/commit/jenkins/2a2a7eb8ed29714961fd145a6186db4aef9d63ba
          Log:
          JENKINS-20951 JENKINS-18410 Did not make it into 1.544 due to validated merge holdups (mostly randomly failing tests, sigh).

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/tasks/junit/TestResultAction.java core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java core/src/main/java/hudson/tasks/test/MatrixTestResult.java test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java http://jenkins-ci.org/commit/jenkins/2a2a7eb8ed29714961fd145a6186db4aef9d63ba Log: JENKINS-20951 JENKINS-18410 Did not make it into 1.544 due to validated merge holdups (mostly randomly failing tests, sigh).

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3111
          [FIXED JENKINS-18410] AbstractTestResultAction should be a RunAction2 so it need not persist its owning build. (Revision fcdf74991226fb6869052caa89ed8d678944b6fc)
          JENKINS-20951 JENKINS-18410 Did not make it into 1.544 due to validated merge holdups (mostly randomly failing tests, sigh). (Revision 2a2a7eb8ed29714961fd145a6186db4aef9d63ba)

          Result = SUCCESS
          Jesse Glick : fcdf74991226fb6869052caa89ed8d678944b6fc
          Files :

          • changelog.html
          • core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java
          • core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java
          • test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java
          • core/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java
          • core/src/main/java/hudson/tasks/test/TestResultAggregator.java
          • core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
          • test/src/test/java/hudson/tasks/test/TrivialTestResultRecorder.java
          • core/src/main/java/hudson/tasks/test/MatrixTestResult.java
          • core/src/main/java/hudson/tasks/junit/TestResultAction.java

          Jesse Glick : 2a2a7eb8ed29714961fd145a6186db4aef9d63ba
          Files :

          • core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
          • core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java
          • test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java
          • core/src/main/java/hudson/tasks/junit/TestResultAction.java
          • changelog.html
          • core/src/main/java/hudson/tasks/test/MatrixTestResult.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3111 [FIXED JENKINS-18410] AbstractTestResultAction should be a RunAction2 so it need not persist its owning build. (Revision fcdf74991226fb6869052caa89ed8d678944b6fc) JENKINS-20951 JENKINS-18410 Did not make it into 1.544 due to validated merge holdups (mostly randomly failing tests, sigh). (Revision 2a2a7eb8ed29714961fd145a6186db4aef9d63ba) Result = SUCCESS Jesse Glick : fcdf74991226fb6869052caa89ed8d678944b6fc Files : changelog.html core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java core/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java core/src/main/java/hudson/tasks/test/TestResultAggregator.java core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java test/src/test/java/hudson/tasks/test/TrivialTestResultRecorder.java core/src/main/java/hudson/tasks/test/MatrixTestResult.java core/src/main/java/hudson/tasks/junit/TestResultAction.java Jesse Glick : 2a2a7eb8ed29714961fd145a6186db4aef9d63ba Files : core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java core/src/main/java/hudson/tasks/junit/TestResultAction.java changelog.html core/src/main/java/hudson/tasks/test/MatrixTestResult.java

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java
          test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java
          http://jenkins-ci.org/commit/jenkins/bfaab5118d079405b82b80301d90e19f39970366
          Log:
          JENKINS-18410 NPE from previous fix (fcdf749) under some conditions, which the test case was not exercising.
          java.lang.NullPointerException
          at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.getProject(AggregatedTestResultPublisher.java:173)
          at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:146)
          at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:135)
          at hudson.tasks.test.AggregatedTestResultPublisher.perform(AggregatedTestResultPublisher.java:90)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java http://jenkins-ci.org/commit/jenkins/bfaab5118d079405b82b80301d90e19f39970366 Log: JENKINS-18410 NPE from previous fix (fcdf749) under some conditions, which the test case was not exercising. java.lang.NullPointerException at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.getProject(AggregatedTestResultPublisher.java:173) at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:146) at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:135) at hudson.tasks.test.AggregatedTestResultPublisher.perform(AggregatedTestResultPublisher.java:90)

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3141
          JENKINS-18410 NPE from previous fix (fcdf749) under some conditions, which the test case was not exercising. (Revision bfaab5118d079405b82b80301d90e19f39970366)

          Result = SUCCESS
          Jesse Glick : bfaab5118d079405b82b80301d90e19f39970366
          Files :

          • core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java
          • test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java
          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #3141 JENKINS-18410 NPE from previous fix (fcdf749) under some conditions, which the test case was not exercising. (Revision bfaab5118d079405b82b80301d90e19f39970366) Result = SUCCESS Jesse Glick : bfaab5118d079405b82b80301d90e19f39970366 Files : core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java changelog.html

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java
          core/src/main/java/hudson/tasks/junit/TestResultAction.java
          core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
          core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java
          core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java
          core/src/main/java/hudson/tasks/test/MatrixTestResult.java
          core/src/main/java/hudson/tasks/test/TestResultAggregator.java
          test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java
          test/src/test/java/hudson/tasks/test/TrivialTestResultRecorder.java
          http://jenkins-ci.org/commit/jenkins/b53770c70f53084bb98e61985a6a9ba0bebdeb75
          Log:
          [FIXED JENKINS-18410] AbstractTestResultAction should be a RunAction2 so it need not persist its owning build.
          (cherry picked from commit fcdf74991226fb6869052caa89ed8d678944b6fc)

          Conflicts:
          changelog.html

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java core/src/main/java/hudson/tasks/junit/TestResultAction.java core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java core/src/main/java/hudson/tasks/test/MatrixTestResult.java core/src/main/java/hudson/tasks/test/TestResultAggregator.java test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java test/src/test/java/hudson/tasks/test/TrivialTestResultRecorder.java http://jenkins-ci.org/commit/jenkins/b53770c70f53084bb98e61985a6a9ba0bebdeb75 Log: [FIXED JENKINS-18410] AbstractTestResultAction should be a RunAction2 so it need not persist its owning build. (cherry picked from commit fcdf74991226fb6869052caa89ed8d678944b6fc) Conflicts: changelog.html

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java
          test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java
          http://jenkins-ci.org/commit/jenkins/b5ec39f0734d05f1de05406a2dddc0bed4440d60
          Log:
          JENKINS-18410 NPE from previous fix (fcdf749) under some conditions, which the test case was not exercising.
          java.lang.NullPointerException
          at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.getProject(AggregatedTestResultPublisher.java:173)
          at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:146)
          at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:135)
          at hudson.tasks.test.AggregatedTestResultPublisher.perform(AggregatedTestResultPublisher.java:90)

          (cherry picked from commit bfaab5118d079405b82b80301d90e19f39970366)

          Conflicts:
          changelog.html

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java http://jenkins-ci.org/commit/jenkins/b5ec39f0734d05f1de05406a2dddc0bed4440d60 Log: JENKINS-18410 NPE from previous fix (fcdf749) under some conditions, which the test case was not exercising. java.lang.NullPointerException at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.getProject(AggregatedTestResultPublisher.java:173) at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:146) at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:135) at hudson.tasks.test.AggregatedTestResultPublisher.perform(AggregatedTestResultPublisher.java:90) (cherry picked from commit bfaab5118d079405b82b80301d90e19f39970366) Conflicts: changelog.html

          The fix to the fix didn't make it to 1.546 it seems, causing both 1.545 and 1.546 to fail jobs in the aggregate test results phase with the NPE listed in the previous comments.

          The workaround for this is to explicitly set the names of the jobs that you want aggregated in your job configuration or to remove the entire aggregate task from the job.

          Derk-Jan Hartman added a comment - The fix to the fix didn't make it to 1.546 it seems, causing both 1.545 and 1.546 to fail jobs in the aggregate test results phase with the NPE listed in the previous comments. The workaround for this is to explicitly set the names of the jobs that you want aggregated in your job configuration or to remove the entire aggregate task from the job.

          Jesse Glick added a comment -

          Correct, the fix should be in 1.547, and the workaround is to set names explicitly. Sorry for any disruption.

          Jesse Glick added a comment - Correct, the fix should be in 1.547, and the workaround is to set names explicitly. Sorry for any disruption.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/tasks/junit/TestResultAction.java
          core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
          core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java
          core/src/main/java/hudson/tasks/test/MatrixTestResult.java
          test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java
          http://jenkins-ci.org/commit/jenkins/412befcb57d520bb1a5a737329785405c8f2c828
          Log:
          JENKINS-20951 JENKINS-18410 Did not make it into 1.544 due to validated merge holdups (mostly randomly failing tests, sigh).

          (cherry picked from commit 2a2a7eb8ed29714961fd145a6186db4aef9d63ba)

          Conflicts:
          changelog.html

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/tasks/junit/TestResultAction.java core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java core/src/main/java/hudson/tasks/test/MatrixTestResult.java test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java http://jenkins-ci.org/commit/jenkins/412befcb57d520bb1a5a737329785405c8f2c828 Log: JENKINS-20951 JENKINS-18410 Did not make it into 1.544 due to validated merge holdups (mostly randomly failing tests, sigh). (cherry picked from commit 2a2a7eb8ed29714961fd145a6186db4aef9d63ba) Conflicts: changelog.html

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: