Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37658

Github-branch-source plugin should support git plugin extensions

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Github branch source should support all the same extensions as the git client plugin ("Clean Before Checkout", "Clean After Checkout ", etc). it currently does not provide a way to add them, while other pipeline plugins do support them.

      See "Additional Behaviors" in the attached screenshot.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            At the same time, should support selection of a browser and a tool.

            Show
            jglick Jesse Glick added a comment - At the same time, should support selection of a browser and a tool.
            Hide
            ahuntpindrop Alex Hunt added a comment -

            This is extremely important, as one of those extensions is 'Advanced checkout behaviors' which allows setting of timeouts for the clone. This allows large repositories to be cloned, which is not possible with the default 10 minute timeout.

            This is a blocker for us, as we have a few repositories which take longer than 10 minutes to clone.

            Show
            ahuntpindrop Alex Hunt added a comment - This is extremely important, as one of those extensions is 'Advanced checkout behaviors' which allows setting of timeouts for the clone. This allows large repositories to be cloned, which is not possible with the default 10 minute timeout. This is a blocker for us, as we have a few repositories which take longer than 10 minutes to clone.
            Hide
            potatopankakes Jeff Burke added a comment -

            Unless there is another ticket for adding submodule support to MBW, or a workaround for not support submodules... this is a blocker for about 50% of the projects I work on.

            Show
            potatopankakes Jeff Burke added a comment - Unless there is another ticket for adding submodule support to MBW, or a workaround for not support submodules... this is a blocker for about 50% of the projects I work on.
            Hide
            jglick Jesse Glick added a comment -

            Alex Hunt Jeff Burke please use the Vote for this issue link in JIRA rather than adding comments, unless you are offering either proposed patches or tested workarounds.

            Show
            jglick Jesse Glick added a comment - Alex Hunt Jeff Burke please use the Vote for this issue link in JIRA rather than adding comments, unless you are offering either proposed patches or tested workarounds.
            Hide
            docwhat Christian Höltje added a comment -

            Will this include a way to trigger those extensions via checkout scm in pipelines?

            Show
            docwhat Christian Höltje added a comment - Will this include a way to trigger those extensions via checkout scm in pipelines?
            Hide
            jglick Jesse Glick added a comment -

            scm should include whatever extensions the branch source was configured to use.

            Show
            jglick Jesse Glick added a comment - scm should include whatever extensions the branch source was configured to use.
            Hide
            docwhat Christian Höltje added a comment -

            But that doesn't make sense when using the github org folders. Different repos would want different settings. Also you can't set them in github org folders.

            Show
            docwhat Christian Höltje added a comment - But that doesn't make sense when using the github org folders. Different repos would want different settings. Also you can't set them in github org folders.
            Hide
            jglick Jesse Glick added a comment -

            Different repos would want different settings.

            Well that would need to be an RFE. Not currently supported—all repositories must use identical settings, except for the remote URL of course. If you want something more complex you need to use Job DSL.

            Show
            jglick Jesse Glick added a comment - Different repos would want different settings. Well that would need to be an RFE. Not currently supported—all repositories must use identical settings, except for the remote URL of course. If you want something more complex you need to use Job DSL.
            Hide
            docwhat Christian Höltje added a comment -

            I created a new RFE, JENKINS-39750.

            Using JobDSL isn't suitable because I'd have to duplicate all the functionality of the GitHub Org Plugin (scanning GitHub, etc.) in the JobDSL, which would be very annoying. And it would still require whomever maintained the jobDSL to know things in advanced (like what the credentials-id is, the URLs, etc.)

            Show
            docwhat Christian Höltje added a comment - I created a new RFE, JENKINS-39750 . Using JobDSL isn't suitable because I'd have to duplicate all the functionality of the GitHub Org Plugin (scanning GitHub, etc.) in the JobDSL, which would be very annoying. And it would still require whomever maintained the jobDSL to know things in advanced (like what the credentials-id is, the URLs, etc.)
            Hide
            myoung34 marc young added a comment -

            This is still an issue even with all the SCM 2.0 work.
            Linking JENKINS-42351

            Show
            myoung34 marc young added a comment - This is still an issue even with all the SCM 2.0 work. Linking JENKINS-42351
            Hide
            pshirshov P S added a comment -

            Related ticket: JENKINS-42947

            Show
            pshirshov P S added a comment - Related ticket:  JENKINS-42947
            Hide
            bitwiseman Liam Newman added a comment -

            Stephen Connolly
            Could you describe why you resolved this a duplicate? I can see that the linked issue has some overlap with this one, but it is not the same thing. This requests that the github branch plugin support the same open-ended set of extensions that the git plugin does. The linked issue implements a limited subset with a different UI.

            Show
            bitwiseman Liam Newman added a comment - Stephen Connolly Could you describe why you resolved this a duplicate? I can see that the linked issue has some overlap with this one, but it is not the same thing. This requests that the github branch plugin support the same open-ended set of extensions that the git plugin does. The linked issue implements a limited subset with a different UI.
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Liam Newman All the extensions available on Git SCM Source are now available on GitHub and Bitbucket (except the ability to set the source code browser, because on GitHub and Bitbucket the only browser to set it to is GitHub / Bitbucket Respectively)

            There were a number of extensions on GitSCM that were exposed to GitSCMSource and should never have been. Those extensions have been removed from GitSCMSource and subclasses.

            The GitHub plugin now supports all the GitSCMExtensions that are relevant in the context of an SCMSource, hence duplicate

            Show
            stephenconnolly Stephen Connolly added a comment - Liam Newman All the extensions available on Git SCM Source are now available on GitHub and Bitbucket (except the ability to set the source code browser, because on GitHub and Bitbucket the only browser to set it to is GitHub / Bitbucket Respectively) There were a number of extensions on GitSCM that were exposed to GitSCMSource and should never have been . Those extensions have been removed from GitSCMSource and subclasses. The GitHub plugin now supports all the GitSCMExtensions that are relevant in the context of an SCMSource, hence duplicate
            Hide
            bitwiseman Liam Newman added a comment -

            Stephen Connolly
            Excellent! Thanks!

            Show
            bitwiseman Liam Newman added a comment - Stephen Connolly Excellent! Thanks!
            Hide
            lucasocio Leandro Lucarella added a comment -

            What about GitHub organizations? When I create an org there is no way to configure this via the config interface. After digging a lot I found https://support.cloudbees.com/hc/en-us/articles/226122247-How-to-Customize-Checkout-for-Pipeline-Multibranch- which helped to finally be able to do this in the Jenkinsfile, but still it's super complicated and you need to mess with permissions approval.

            Show
            lucasocio Leandro Lucarella added a comment - What about GitHub organizations? When I create an org there is no way to configure this via the config interface. After digging a lot I found https://support.cloudbees.com/hc/en-us/articles/226122247-How-to-Customize-Checkout-for-Pipeline-Multibranch- which helped to finally be able to do this in the Jenkinsfile, but still it's super complicated and you need to mess with permissions approval.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              bitwiseman Liam Newman
              Votes:
              44 Vote for this issue
              Watchers:
              43 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: