Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40755

Settings link appears when user does not have edit permissions

    XMLWordPrintable

Details

    • tethys, pannonian, iapetus

    Description

      We need to check if the current user has the edit permission when choosing to display the cog icon on the result screen.

      In Scope

      • Audit all the locations where we show the settings link to ensure that that they honour the edit permission
      • update any that do not honour the edit permission

      Attachments

        1. 1.png
          1.png
          73 kB
        2. 2.png
          2.png
          68 kB

        Activity

          Ascending order - Click to sort in descending order
          jamesdumay James Dumay added a comment -

          michaelneale I think its only fair that you get to fix this one

          jamesdumay James Dumay added a comment - michaelneale I think its only fair that you get to fix this one
          tfennelly Tom FENNELLY added a comment -

          Hmmm ... need to talk to vivek about this. We need some way of checking a user permission on a domain object. I don't see that there atm.

          tfennelly Tom FENNELLY added a comment - Hmmm ... need to talk to vivek about this. We need some way of checking a user permission on a domain object. I don't see that there atm.
          tfennelly Tom FENNELLY added a comment -

          And I'm not sure adding user/requester specific data onto the side of these domain object REST responses would be very restful as it it would make them uncacheable etc.

          tfennelly Tom FENNELLY added a comment - And I'm not sure adding user/requester specific data onto the side of these domain object REST responses would be very restful as it it would make them uncacheable etc.
          tfennelly Tom FENNELLY added a comment -

          https://github.com/jenkinsci/blueocean-plugin/pull/825

          tfennelly Tom FENNELLY added a comment - https://github.com/jenkinsci/blueocean-plugin/pull/825

          People

            tfennelly Tom FENNELLY
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: