Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42120

Revisit Git repository creation flow credential setup

    XMLWordPrintable

Details

    • iapetus, 1.0, Blue Ocean 1.0-rc3

    Description

      Scope

      • Drop down with existing credentials & add button to the right.
      • If no existing credentials, show "none" in dropdown
      • Clicking add launches the modal to add credential.
      • Once credential is added, modal is dismissed & the credential that was just added populates the dropdown
      • Do not provide the "Use system ssh" option - remove it for now and it can be revisited later if there are too many complaints
      • Integrate eager validation as described in JENKINS-41597 into this ticket
      • Integrate showing/hiding credentials dropdown and "add" button based on credential permissions JENKINS-41573

      Design brief
      We need a better design for using existing credentials or creating a new credential. I realise this was my original design but it is confusing.

      Perhaps we ask them to choose between a new credential or existing one then show the form to select/create a new credential depending on the option picked.

      Should we show "existing credential" if there there are no existing credentials to pick from?

      Attachments

        1. Git Step 1.png
          Git Step 1.png
          72 kB
        2. Git Step 1 Copy.png
          Git Step 1 Copy.png
          61 kB
        3. screenshot-1.png
          screenshot-1.png
          7 kB

        Issue Links

          duplicates

          Task - A task that needs to be done. JENKINS-41397 API to validate Git credentials

          • Major - Major loss of function.
          • Resolved
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-42719 Bug fixes / enhancements to Dropdown

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. JENKINS-41397 API to validate Git credentials

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-41573 Git Creation needs to better handle users with restricted credential permissions

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-42972 When trying to create a pipeline from git, credentials are not stored on save

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-42987 [Safari] Rendering defect on Existing Credential dropdown in New Pipeline screen

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-41597 Git Creation flow eager validation in UI

          • Major - Major loss of function.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            View 6 older comments
            jamesdumay James Dumay added a comment -

            cliffmeyers "Cancel" will do

            jamesdumay James Dumay added a comment - cliffmeyers "Cancel" will do
            brody Brody Maclean added a comment -

            cliffmeyers Looks like jamesdumay beat me to the punch.
            Let me know if there are any unanswered questions.

            FYI Cancel should be the secondary button

            brody Brody Maclean added a comment - cliffmeyers Looks like jamesdumay beat me to the punch. Let me know if there are any unanswered questions. FYI Cancel should be the secondary button
            cliffmeyers Cliff Meyers added a comment -

            This ticket is still in-progress but pending some merging and fixes in JENKINS-41397 that are currently in-progress. I think the UI work is basically done but I uncovered some unexpected behavior in the REST API while testing. Unfortunately testing this change is very time consuming given the permutations (roughly 2^5... SCM provider, repo visibility, URL scheme, credential type, credential validity).

            cliffmeyers Cliff Meyers added a comment - This ticket is still in-progress but pending some merging and fixes in JENKINS-41397 that are currently in-progress. I think the UI work is basically done but I uncovered some unexpected behavior in the REST API while testing. Unfortunately testing this change is very time consuming given the permutations (roughly 2^5... SCM provider, repo visibility, URL scheme, credential type, credential validity).
            jamesdumay James Dumay added a comment -

            Thanks for the update cliffmeyers - no rush

            jamesdumay James Dumay added a comment - Thanks for the update cliffmeyers - no rush
            michaelneale Michael Neale added a comment - - edited

            Bumping this to critical now - as ssh credentials for git do not work at all - even if you put a private key in, it won't use it and instead tries to use system.  cc vivek

            michaelneale Michael Neale added a comment - - edited Bumping this to critical now - as ssh credentials for git do not work at all - even if you put a private key in, it won't use it and instead tries to use system.  cc vivek

            People

              cliffmeyers Cliff Meyers
              jamesdumay James Dumay
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: