[JENKINS-26481] Mishandling of binary methods accepting Closure - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Critical
Resolution: Fixed
Component/s: workflow-cps-plugin
Labels:
Environment:
Jenkins LTS 1.580.2 and workflow-plugin 1.1. Both are the latest versions at the time of this writing. Tested on RHEL 6 with OpenJDK 1.7 and Fedora 21 with OpenJDK 1.8.

Similar Issues:

Show
Epic Link:
Pipeline Groovy

Description

At least some closures are executed only once inside of Groovy CPS DSL scripts managed by the workflow plugin.

Steps to reproduce:
1. Create a new workflow with the following script:
node {
[1, 2, 3].each

{ println it }

println "abc".replaceAll(/[a-z]/)

{ it.toUpperCase() }

}
2. Build the workflow

Actual output:
Started by user anonymous
Running: Allocate node : Start
Running on master in /var/lib/jenkins/jobs/testflow/workspace
Running: Allocate node : Body : Start
Running: Print Message
1
Running: Print Message
A
Running: Allocate node : Body : End
Running: Allocate node : End
Running: End of Workflow
Finished: SUCCESS

Expected output:
Started by user anonymous
Running: Allocate node : Start
Running on master in /var/lib/jenkins/jobs/testflow/workspace
Running: Allocate node : Body : Start
Running: Print Message
1
Running: Print Message
2
Running: Print Message
3
Running: Print Message
ABC
Running: Allocate node : Body : End
Running: Allocate node : End
Running: End of Workflow
Finished: SUCCESS

Attachments

Issue Links

blocks

JENKINS-40864 Cannot execute Git branch list command in order to populate dynamically a choice pipeline property component

Resolved

depends on

JENKINS-34064 Pipeline builds do not run after Groovy 2.x upgrade

Resolved

JENKINS-27421 Unserializable iterator & entry classes from Java Collections

Resolved

is blocked by

JENKINS-44924 pipeline groovy script - Sort a list with custom comparator or closure not sorting

In Progress

JENKINS-44578 StackOverflowError in CpsTransformer running Declarative on JVMs with small -Xss in workflow-cps 2.33

Resolved

JENKINS-46703 File.eachFileRecurse(FileType.FILES) and File.eachDirRecurse() only loops for first element

Resolved

is duplicated by

JENKINS-38268 Parallel step and closure scope

Resolved

JENKINS-28276 Map collectEntries closure not behaving correctly

Resolved

JENKINS-32451 Collection.find returns boolean

Resolved

JENKINS-37303 .eachDir() iterate only once

Resolved

JENKINS-38052 Pipeline parallel map not supporting curried closures

Resolved

JENKINS-42635 Passing Closures to NonCPS Library Function give strange results

Resolved

JENKINS-42769 NonCPS function returns wrong results!

Resolved

JENKINS-26699 Workflow plugin silently breaks regular Groovy maps

Resolved

JENKINS-35637 Pipeline plugin groovy interpreter does not interpret splitEachLine() for all lines

Resolved

JENKINS-40339 Jenkins parallel pipeline: All subroutine calls in parameter blocks pass arguments from last block

Resolved

JENKINS-41493 each and collect methods on lists do not work properly

Resolved

JENKINS-43519 security sandbox should whitelist #eachWithIndex

Resolved

is related to

JENKINS-26300 CPS interpreter fails on calls to find(), findAll() default methods

Resolved

JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly

Resolved

JENKINS-28599 Inconsistent behavior of collect

Resolved

relates to

JENKINS-46747 Reader.forEachLine only reads first line

Open

JENKINS-46749 .collect, then .each still results in closure being invoked only for first element

Open

JENKINS-41189 [Pipeline] Some non-CPS transformable code will not throw errors

Resolved

JENKINS-54982 Using Java8 Streams evaluates whole expression to Boolean

Open

JENKINS-42024 Silent error : UnsupportedOperationExceptions are not raised when using each/find

Resolved

links to

CloudBees Internal OSS-1410

In-progress DGM patching PR (groovy-cps #52)

PR 372

workflow-cps PR 15

workflow-cps PR 124

(1 is blocked by, 12 is duplicated by, 3 is related to, 5 relates to, 9 links to)

Activity

Ascending order - Click to sort in descending order

Daniel Tschan created issue - 2015-01-18 19:04

Jesse Glick made changes - 2015-01-20 16:59

Field	Original Value	New Value
Assignee	Jesse Glick [ jglick ]	Kohsuke Kawaguchi [ kohsuke ]

Jesse Glick made changes - 2015-01-30 15:06

Link

This issue is duplicated by ~~JENKINS-26699~~ [ ~~JENKINS-26699~~ ]

Jesse Glick made changes - 2015-02-25 22:34

Link

This issue is related to ~~JENKINS-26300~~ [ ~~JENKINS-26300~~ ]

Jesse Glick made changes - 2015-03-13 10:50

Remote Link

This issue links to "groovy-cps #8 (Web Link)" [ 12153 ]

Jesse Glick made changes - 2015-03-13 10:52

Remote Link

This issue links to "groovy-cps #9 (Web Link)" [ 12154 ]

Jesse Glick made changes - 2015-03-13 10:54

Remote Link

This issue links to "groovy-cps #7 (Web Link)" [ 12155 ]

Jesse Glick made changes - 2015-03-13 17:26

Status

Open [ 1 ]

In Progress [ 3 ]

Jesse Glick made changes - 2015-03-17 20:12

Summary

Closures only executed once in Groovy CPS DSL scripts

Mishandling of binary methods accepting Closure

Back Slasher made changes - 2015-05-27 13:51

Link

This issue is related to ~~JENKINS-28599~~ [ ~~JENKINS-28599~~ ]

Jesse Glick made changes - 2015-10-30 13:42

Link

This issue is related to ~~JENKINS-31314~~ [ ~~JENKINS-31314~~ ]

Jesse Glick made changes - 2015-11-19 21:17

Labels

kohsuke-plane-project

Jesse Glick made changes - 2016-03-31 20:51

Remote Link

This issue links to "PR 372 (Web Link)" [ 14143 ]

Jesse Glick made changes - 2016-04-03 02:01

Link

This issue depends on ~~JENKINS-27421~~ [ ~~JENKINS-27421~~ ]

Jesse Glick made changes - 2016-04-06 20:00

Link

This issue depends on ~~JENKINS-34064~~ [ ~~JENKINS-34064~~ ]

Niristotle Okram made changes - 2016-04-25 22:53

Comment

[ Using latest pipeline plugin(s) of 2.1. The below code worked once with the iteration. And it stopped (strange) why only once.

node('win-slave4') {
checkout([$class: 'GitSCM', branches: [[name: '*/master']], doGenerateSubmoduleConfigurations: false, extensions: [[$class: 'CleanBeforeCheckout']], submoduleCfg: [], userRemoteConfigs: [[credentialsId: 'cca9c557-2-9176-f78d91c22907', url: 'git@github.com:someProjects/testopy.git']]])

def paths = ['folder1', 'folder2', 'folder3']
def dirs = ['dst1', 'dst2', 'dst3']

[paths, dirs].transpose().each { pd ->
    def path = pd[0]
    def dir = pd[1]
    bat "xcopy %cd%\\${path} C:\\${dir} /E /Y /V"
    }
  } ]

Jesse Glick made changes - 2016-05-19 18:21

Link

This issue is duplicated by ~~JENKINS-32451~~ [ ~~JENKINS-32451~~ ]

Jesse Glick made changes - 2016-06-06 14:02

Labels

kohsuke-plane-project

groovy kohsuke-plane-project

Jesse Glick made changes - 2016-06-06 14:06

Remote Link

This issue links to "workflow-cps PR 15 (Web Link)" [ 14412 ]

Jesse Glick made changes - 2016-06-06 14:06

Remote Link

This issue links to "groovy-cps PR 24 (Web Link)" [ 14413 ]

Jesse Glick made changes - 2016-06-06 18:48

Epic Link

JENKINS-35390 [ 171183 ]

Jesse Glick made changes - 2016-06-06 21:15

Link

This issue is duplicated by ~~JENKINS-28276~~ [ ~~JENKINS-28276~~ ]

Daniel Beck made changes - 2016-07-11 14:55

Link

This issue is duplicated by ~~JENKINS-35637~~ [ ~~JENKINS-35637~~ ]

R. Tyler Croy made changes - 2016-07-25 23:53

Workflow

JNJira [ 160549 ]

JNJira + In-Review [ 185567 ]

Andrew Bayer made changes - 2016-08-26 21:49

Component/s

pipeline-general [ 21692 ]

Andrew Bayer made changes - 2016-08-26 21:54

Component/s

workflow-plugin [ 18820 ]

Jesse Glick made changes - 2016-08-29 17:23

Component/s		workflow-cps-plugin [ 21713 ]
Component/s	pipeline [ 21692 ]

Andrew Bayer made changes - 2016-10-12 10:28

Link

This issue is duplicated by ~~JENKINS-38268~~ [ ~~JENKINS-38268~~ ]

Andrew Bayer made changes - 2016-10-12 10:28

Link

This issue is duplicated by ~~JENKINS-38052~~ [ ~~JENKINS-38052~~ ]

Daniel Beck made changes - 2016-12-30 13:18

Link

This issue is duplicated by ~~JENKINS-37303~~ [ ~~JENKINS-37303~~ ]

Ryan Campbell made changes - 2017-01-03 16:24

Labels

groovy kohsuke-plane-project

groovy kohsuke-plane-project pipeline-hangs

Marcelo Filho made changes - 2017-01-06 16:04

Link

This issue blocks ~~JENKINS-40864~~ [ ~~JENKINS-40864~~ ]

Jesse Glick made changes - 2017-02-01 21:48

Link

This issue relates to ~~JENKINS-41189~~ [ ~~JENKINS-41189~~ ]

Jesse Glick made changes - 2017-02-10 20:34

Link

This issue is duplicated by ~~JENKINS-41493~~ [ ~~JENKINS-41493~~ ]

Jesse Glick made changes - 2017-02-15 21:47

Link

This issue relates to ~~JENKINS-42024~~ [ ~~JENKINS-42024~~ ]

Andrew Bayer made changes - 2017-03-28 22:45

Link

This issue is duplicated by ~~JENKINS-42769~~ [ ~~JENKINS-42769~~ ]

Andrew Bayer made changes - 2017-03-28 22:47

Link

This issue is duplicated by ~~JENKINS-42635~~ [ ~~JENKINS-42635~~ ]

Marat S made changes - 2017-03-29 17:50

Priority

Major [ 3 ]

Critical [ 2 ]

Andrew Bayer made changes - 2017-05-11 16:12

Assignee

Kohsuke Kawaguchi [ kohsuke ]

Andrew Bayer [ abayer ]

Andrew Bayer made changes - 2017-05-11 16:34

Remote Link

This issue links to "In-progress DGM patching PR (groovy-cps #52) (Web Link)" [ 16508 ]

Jesse Glick made changes - 2017-05-11 21:19

Remote Link

This issue links to "workflow-cps PR 124 (Web Link)" [ 16509 ]

Jesse Glick made changes - 2017-05-16 13:16

Assignee

Andrew Bayer [ abayer ]

Jesse Glick [ jglick ]

Jesse Glick made changes - 2017-05-24 19:05

Status

In Progress [ 3 ]

In Review [ 10005 ]

Jesse Glick made changes - 2017-05-30 23:06

Resolution		Fixed [ 1 ]
Status	In Review [ 10005 ]	Resolved [ 5 ]

Jesse Glick made changes - 2017-06-01 14:07

Link

This issue is blocked by ~~JENKINS-44578~~ [ ~~JENKINS-44578~~ ]

Jesse Glick made changes - 2017-06-05 14:18

Link

This issue is duplicated by ~~JENKINS-43519~~ [ ~~JENKINS-43519~~ ]

Jesse Glick made changes - 2017-06-15 22:15

Link

This issue is blocked by JENKINS-44924 [ JENKINS-44924 ]

Jakub Bochenski made changes - 2017-09-08 13:12

Link

This issue relates to JENKINS-46747 [ JENKINS-46747 ]

Jakub Bochenski made changes - 2017-09-08 13:30

Link

This issue relates to JENKINS-46749 [ JENKINS-46749 ]

Jesse Glick made changes - 2017-09-18 20:40

Link

This issue is blocked by ~~JENKINS-46703~~ [ ~~JENKINS-46703~~ ]

CloudBees Inc. made changes - 2017-12-05 05:45

Remote Link

This issue links to "CloudBees Internal OSS-1410 (Web Link)" [ 18706 ]

Andrew Bayer made changes - 2018-02-23 21:49

Link

This issue is duplicated by ~~JENKINS-40339~~ [ ~~JENKINS-40339~~ ]

Devin Nusbaum made changes - 2018-12-14 18:48

Link

This issue relates to JENKINS-54982 [ JENKINS-54982 ]

People

Assignee:: Jesse Glick

Reporter:: Daniel Tschan

Votes:: 108 Vote for this issue

Watchers:: 136 Start watching this issue

Dates

Created:: 2015-01-18 19:04

Updated:: 2019-07-23 15:37

Resolved:: 2017-05-30 23:06